Skip to content

feat: optimize the active init operation of zero-initialized memory of makeFieldInitializationInConstructor #2948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
KKiiim wants to merge 11 commits into from
Closed

feat: optimize the active init operation of zero-initialized memory of makeFieldInitializationInConstructor #2948

KKiiim wants to merge 11 commits into from

Conversation

@KKiiim
Copy link

@KKiiim KKiiim commented Sep 17, 2025 •
edited
Loading

  • Reduce unnecessary zero-initialization memory in the constructor

  • According to wasm-spec, grown memories should initialized with value 0x00

  • I've read the contributing guidelines

  • I've added my name and email to the NOTICE file

@KKiiim KKiiim changed the title feat: remove the active init operation of zero-initialized memory of makeFieldInitializationInConstructor feat: optimize the active init operation of zero-initialized memory of makeFieldInitializationInConstructor Sep 17, 2025
HerrCai0907
HerrCai0907 reviewed Sep 17, 2025
View reviewed changes
Copy link
Member

@HerrCai0907 HerrCai0907 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

optimization goal LGTM. But I think we should only check whether the field is straightly initialized by zero and ignore it.

MaxGraey
MaxGraey reviewed Sep 17, 2025
View reviewed changes
HerrCai0907 pushed a commit to wasm-ecosystem/warpo that referenced this pull request Sep 19, 2025
@KKiiim @atc-github
feat(as): optimize zero-initialized member variable (#120)
867a65f 
AssemblyScript/assemblyscript#2948
HerrCai0907 pushed a commit to wasm-ecosystem/warpo that referenced this pull request Sep 23, 2025
@KKiiim @HerrCai0907
feat(as): optimize zero-initialized member variable (#120)
3f30e04 
AssemblyScript/assemblyscript#2948
@KKiiim
Copy link
Author

KKiiim commented Sep 25, 2025

@CountBleck Could you please have a look on this PR (^_^)

CountBleck
CountBleck reviewed Sep 25, 2025
View reviewed changes
Copy link
Member

@CountBleck CountBleck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems mostly okay, but I'm wondering what all the removed $~lib/arraybuffer/ArrayBufferView#set:buffer is about...what is that setter function supposed to be doing anyway?

I'd like @MaxGraey to sign off before merging.

@KKiiim KKiiim requested a review from CountBleck October 2, 2025 07:01
@KKiiim KKiiim mentioned this pull request Oct 4, 2025
Merged
HerrCai0907
HerrCai0907 reviewed Oct 11, 2025
View reviewed changes
HerrCai0907 pushed a commit to wasm-ecosystem/warpo that referenced this pull request Oct 11, 2025
@KKiiim
fix(as): init unmanaged class (#26)
fd0f3aa 
AssemblyScript/assemblyscript#2948
@KKiiim
Copy link
Author

KKiiim commented Oct 11, 2025

@coderabbitai summary

@KKiiim
Copy link
Author

KKiiim commented Oct 15, 2025 •
edited
Loading

Ping @MaxGraey @CountBleck Thanks for review again

@KKiiim KKiiim requested a review from HerrCai0907 October 25, 2025 08:56
@KKiiim
Copy link
Author

KKiiim commented Oct 30, 2025

Ping for review @MaxGraey @CountBleck @HerrCai0907

@github-actions
Copy link

github-actions bot commented Dec 29, 2025

This PR has been automatically marked as stale because it has not had recent activity. It will be closed in one week if no further activity occurs. Thank you for your contributions!

@github-actions github-actions bot added the stale label Dec 29, 2025
@github-actions
Copy link

github-actions bot commented Jan 5, 2026

This PR has been automatically closed due to lack of recent activity, but feel free to reopen it as long as you merge in the main branch afterwards.

@github-actions github-actions bot closed this Jan 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MaxGraey MaxGraey Awaiting requested review from MaxGraey

@CountBleck CountBleck Awaiting requested review from CountBleck

@HerrCai0907 HerrCai0907 Awaiting requested review from HerrCai0907

Assignees

No one assigned

Labels

stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@KKiiim @MaxGraey @HerrCai0907 @CountBleck